nickwallen commented on issue #1386: METRON-2078: Remove Storm dependency from metron-writer URL: https://github.com/apache/metron/pull/1386#issuecomment-484987067 +1 Pending the manual tests that you referenced. This looks solid and straight forward. Nice work. I was able to validate the end-to-end flow of alerts, along with the Profiler in Storm, Spark and the REPL. If you can confirm validation of the other items, let's ship this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
