nickwallen commented on issue #1383: METRON-1788 Batch profiler pull profile information from zookeeper URL: https://github.com/apache/metron/pull/1383#issuecomment-487968401 In your PR description, we also need a list of steps to manually verify the functionality. These steps just serve as acceptance criteria and helps ensure the community understands what functionality you are delivering. Yours would just consist of the steps that you took to validate this in the dev environment. It might just involve something like spin-up full dev, load a profile definition in Zk, run the batch profiler with --zookeeper, and validate. It is also very common to crib testing steps from previous PRs; for example https://github.com/apache/metron/pull/1191.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
