mmiklavc edited a comment on issue #1360: METRON-1856: Parser aggregation URL: https://github.com/apache/metron/pull/1360#issuecomment-488119115 @ruffle1986 - it still looks like there's still something amiss with this PR. Can you re-apply your changes on a clean branch so there aren't 145 commits? As I look through the commit history, this looks like it was a collaborative effort with @tiborm, however I only see your name on it. Either this should be split up, or more likely it looks like this belongs in a feature branch. Either way, we can't accept this in this state. EDIT - I'm also concerned about the size of the change here weighing in at 5k lines. We've discussed this multiple times before as a community, and it was agreed that this large of a change should 1. Have a discuss thread, minimally, to start the initiative. Screenshots, mockups, and/or diagrams are welcome and appropriate. 2. Probably have a feature branch to foster the review process. Ideally, the series of commits dating back to November of 2018 would have been submitted for discussion and review in the feature branch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
