ruffle1986 commented on issue #1360: METRON-1856: Parser aggregation URL: https://github.com/apache/metron/pull/1360#issuecomment-488577944 @mmiklavc There's definitely something wrong with the commit history so I'm gonna clean this up once and for all. Everyone in the UI team has worked on this. The reason why you can see my name everywhere is because I had to clean the commit history last year as well because it was messed. It seems like it's the nature of this long living feature branch and there must be something wrong with our approach to keep it up-to-date with the master. First I tried rebasing it with master but it caused headaches when others wanted to have the latest version on their local computer. Then we agreed on using merging commits to make it obvious what was going on. We already have a discussion thread on this. Unfortunately I couldn't find it the mailing list but remember? This was the thread where we introduced the benefits of a better state management strategy and a new module called Ngrx. As I can remember, you liked the idea and we got the green light. However the commit history is messed up, once it's solved, I think it's enough to introduce this change set in one feature branch because it's one feature called Parser Aggregation. For the record, @merrimanr reviewed it a few months ago and he liked the approach how we achieved better state management. He reported a few bugs and we also found a few after manual testing and we also found some uncovered edge cases. It had never been easier to scale the UI code and add the required features, fixes in order to meet the criteria. Steps: - Clean up the commit history - Wire @merrimanr 's changes regarding this: https://github.com/apache/metron/pull/1396 - Start a [DISCUSS] thread on who, what, why. Does that make sense? cc @ottobackwards
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
