simonellistonball commented on a change in pull request #1408: METRON-2118:
Added a LEEF parser
URL: https://github.com/apache/metron/pull/1408#discussion_r285648791
##########
File path:
metron-platform/metron-parsing/metron-parsers/src/main/java/org/apache/metron/parsers/cef/CEFParser.java
##########
@@ -45,7 +45,7 @@
private static final Charset UTF_8 = Charset.forName("UTF-8");
private Pattern p;
- private Pattern pext;
+ private static final Pattern pext =
Pattern.compile(EXTENSION_CAPTURE_PATTERN);
Review comment:
I kinda left that as out of scope since it's in the CEF parser, not the LEEF
parser (the LEEF version doesn't use that technique). I'll fix it anyway,
although I would say it was a bit of out of the scope of this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
