ruffle1986 commented on issue #1380: METRON-1253: Manual pasting of timestamps into the timestamp picker URL: https://github.com/apache/metron/pull/1380#issuecomment-494688329 @sardell Thank you for the suggestions, they are all good points. But, with your changes, I'm still experiencing the "flash of date picker" after manually pasting a date and clicking outside of the input element. I think it's not a big deal especially when I look at the other disadvantages I'm experiencing also. However, with the patch we can enable this toggling functionality which is great, but now, this is the only way to hide the date picker if I don't want to set a date from the picker. So for me, it hasn't make it any better or user friendlier. It also breaks the cypress tests and adds a lot of complexity in order to add something that should be convenient but not really is. It also breaks the date pickers on the PCAP panel so additional css hacks are needed to get rid of the bad parts that are introduced by the suggested patch. So long story short, I think these changes are not necessary and are not worth the effort. I'd like you to reconsider the PR based on my concerns. Thank you in advance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
