mmiklavc commented on issue #1419: METRON-2128: LEEF config file is missing in 
RPM spec file
URL: https://github.com/apache/metron/pull/1419#issuecomment-495013460
 
 
   > Agreed, but that’s what the integration tests look for, so that’s where it 
needs to live to get the integration tests required by you comments on the 
other PR. Can you suggest where it should go, and how we should change the 
integration test approach?
   
   It actually checks for zookeeper config in both 
`metron-parsing/metron-parsers` and `metron-parsing/metron-parsers-common` - 
https://github.com/apache/metron/blob/22cc622d6f08cfa77c06dea2df7f4c56edc1862e/metron-platform/metron-parsing/metron-parsers-common/src/test/java/org/apache/metron/parsers/integration/ParserIntegrationTest.java#L67.
 I didn't actually realize that until I dug a bit. Echoing our earlier 
thoughts, I would like to simplify this a bit at some point so that the 
concerns aren't jumbled.
   
   That being said, the leef config should go here - 
https://github.com/apache/metron/tree/22cc622d6f08cfa77c06dea2df7f4c56edc1862e/metron-platform/metron-parsing/metron-parsers/src/main/config/zookeeper/parsers
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to