merrimanr commented on a change in pull request #1396: METRON-2034: REST 
endpoint for getting all parser topology status should return group name
URL: https://github.com/apache/metron/pull/1396#discussion_r287146418
 
 

 ##########
 File path: metron-platform/metron-common/src/main/config/zookeeper/global.json
 ##########
 @@ -6,5 +6,16 @@
   "update.hbase.table": "metron_update",
   "update.hbase.cf": "t",
   "es.client.settings": {
-  }
+  },
+  "parser.groups": [
 
 Review comment:
   I spent some time trying to document this and I realized the documentation 
doesn't make much sense because the UI component hasn't been done yet.  I find 
myself guessing how it is going to work because I'm not 100% clear on how the 
UI will function and I don't have anything to reference because that work is 
still being submitted.  Almost all of the requests in your list involve the UI 
in some way.  Parser group and parser aggregation are synonymous so that's 
something else we'll want to fix. 
   
   I think I may put this on hold until the UI part is further along unless you 
would accept that work as a follow on Jira that blocks the acceptance of this 
feature branch.  The benefit of committing this now is it will resolve a bug 
that was found earlier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to