sardell commented on issue #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table URL: https://github.com/apache/metron/pull/1431#issuecomment-498320419 > What's the plan for handling this feature flag? @mmiklavc After thinking about it, I feel like this implementation is less like a feature flag and more like a configuration option. I say this because, from how I understand it, feature flags are meant to eventually be included to all users. From what I can tell, this is not a feature that all users will want to turn on because of the required configuration (@tiborm correct me if I'm wrong here). > What happens if you type "fasle" for isEnabled? Good point. I just built the Alerts app with Angular CLI and it completed successfully with that typo. I haven't been able to test the other non-happy/failure path scenarios you mention, but these are all good points. > These instructions should have a dedicated section in the documentation/README for the Alerts UI. @tiborm Let me know if I can help with this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
