tiborm commented on issue #1431: METRON-2102: [UI] Adding click-through navigation to Alerts table URL: https://github.com/apache/metron/pull/1431#issuecomment-499530840 @mmiklavc @sardell I was extended the validation of context-menu.conf.json and covered all scenarios with unit tests. Alerts UI validates possible issues with config JSON and provides error log in the browser console. I also extended app-config.service with validation, logging and unit tests. The reason why I did that in the scope of this changeset is bc app-config contains **contextMenuConfigURL** entry. Alerts UI's app config is managed by Ambari. I found better to check the existence of required app config entries in the client and provide error logs if something missing. This makes debugging easier in a deployed environment if it's needed. Also extended and added feature documentation as a [README.md](https://github.com/tiborm/metron/blob/METRON-2102-click-through-menu/metron-interface/metron-alerts/src/app/shared/context-menu/README.md) I hope covered everything we discussed. Thank you for reviewing!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
