mmiklavc commented on issue #1374: METRON-2061: Solr documents with date fields cannot be updated with Dao classes URL: https://github.com/apache/metron/pull/1374#issuecomment-501453074 How is this DAO and jsonpatch being used by the meta-alert infrastructure? This manual test is picking a fairly narrow interpretation of all that can be done with JsonPatch, and I'm unclear whether we're introducing a feature regression here or not. I know we're using json patch (separately) for handling Ambari modifications to global config to ensure we don't trample user-added or other type of updates that aren't managed by Ambari. I'm concerned about what's not covered by switching from json patch to our own private version of it, specifically here. Very likely, the existing unit and integration tests are only verifying some basic functionality wrt the jsonpatch library (we are depending on the jsonpatch project to handle the fine grained testing of all the RFC details for us), so if we're going to replace it I think we need to do one of the following: 1. (preferred) Own all of the test scenarios as defined in https://tools.ietf.org/html/rfc6902 to ensure we meet the spec and do not introduce any regressions. 2. Modify the documentation, whether in our REST API implementation details for UI devs or in user-facing docs, to be explicit about what patching functionality we are or are not planning to support. If we are walking back functionality by choosing option 2, I think this needs to be accompanied with a proper DISCUSS thread and a feature change notice in the release/upgrading notes. In addition, we would need to: 1. Expand the manual test cases to include any existing features in the UI to ensure we we haven't removed or altered what is expected from RFC 6902 2. Add additional unit and integration tests to cover cases not already handled by the automated testing framework.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
