nickwallen edited a comment on issue #1451: METRON-2168 Elasticsearch Updates Not Tested in Integration Test URL: https://github.com/apache/metron/pull/1451#issuecomment-506812474 One point that reviewers should consider is do we have enough test coverage for the `MultiIndexDao` now? I don't think the `MultiIndexDao` warrants an integration test. It doesn't integrate with any external systems. I think it can be tested sufficiently with unit testing. But is what we have in `MultiIndexDaoTest` enough? **update**: My answer would lean on the "no" side, but I don't think the integration tests really covered any of the existing gaps. I might spend a bit of time expanding on `MultiIndexDaoTest` as part of this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
