mmiklavc commented on a change in pull request #1465: METRON-2172 Solr Updates
Not Tested in Integration Test
URL: https://github.com/apache/metron/pull/1465#discussion_r305115702
##########
File path:
metron-platform/metron-solr/metron-solr-common/src/test/java/org/apache/metron/solr/dao/SolrSearchDaoTest.java
##########
@@ -510,5 +512,13 @@ public void
getGroupResultsShouldProperlyReturnGroupResults() {
assertNull(level2GroupResults.get(1).getGroupResults());
}
-
+ private SolrDocument createSolrDocument(String sensorType, Long timestamp) {
Review comment:
Thank you for this - simple types like this should not be mocked. Good
improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
