nickwallen commented on a change in pull request #1470: METRON-2193 Upgrade
Enrichments for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1470#discussion_r307487088
##########
File path: metron-platform/metron-common/pom.xml
##########
@@ -383,6 +383,10 @@
<pattern>com.google.common</pattern>
<shadedPattern>org.apache.metron.guava.${guava_version}</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>com.google.thirdparty</pattern>
+
<shadedPattern>org.apache.metron.guava.thirdparty.${guava_version}</shadedPattern>
Review comment:
This fixes an error with `SimpleFlatFileSummarizerTest.testWholeFile` caused
by how we relocate Guava.
We relocate `com.google.common` which does not include all packages within
Guava. It specifically misses
`com.google.thirdparty.publicsuffix.PublicSuffixPatterns` which is the root
cause of this test failure.
We may want to ensure that we relocate everything under `com.google`
everywhere, but I didn't want to make such a drastic change just yet. And I
know @merrimanr has a PR out that may shuffle what we need to do here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
