mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade
Profiler for HBase 2.0.2
URL: https://github.com/apache/metron/pull/1458#discussion_r308999830
##########
File path:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java
##########
@@ -241,10 +241,18 @@ public SaltyRowKeyBuilder(int saltDivisor, long
duration, TimeUnit units) {
}
}
+ public long getPeriodDurationMillis() {
+ return periodDurationMillis;
+ }
+
public void withPeriodDuration(long duration, TimeUnit units) {
periodDurationMillis = units.toMillis(duration);
}
+ public int getSaltDivisor() {
Review comment:
This is my first time seeing this class. General Q about what this is for.
Is this different from other core HBase code in the rest of Metron around
enrichments? If we are duplicating logic in different areas of the application
I think we need to add a Jira to the feature branch to reconcile some of this
to some extent before we polish off the upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
