ottobackwards commented on a change in pull request #1475: METRON-2197 Add
debugging info output for Solr queries
URL: https://github.com/apache/metron/pull/1475#discussion_r310398924
##########
File path:
metron-platform/metron-solr/metron-solr-common/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
##########
@@ -91,29 +106,28 @@ public SearchResponse search(SearchRequest searchRequest,
String fieldList)
throw new InvalidSearchException(
"Search result size must be less than " +
accessConfig.getMaxSearchResults());
}
- try {
- SolrQuery query = buildSearchRequest(searchRequest, fieldList);
- QueryResponse response = client.query(query);
- return buildSearchResponse(searchRequest, response);
- } catch (SolrException | IOException | SolrServerException e) {
- String msg = e.getMessage();
- LOG.error(msg, e);
- throw new InvalidSearchException(msg, e);
+ }
+
Review comment:
We can add that as a follow on really, I just wanted to point that out. We
should be explicit about the intended use case here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
