nickwallen commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r311169680
########## File path: metron-analytics/metron-profiler-storm/src/main/config/profiler.properties ########## @@ -61,6 +61,8 @@ profiler.hbase.table=profiler profiler.hbase.column.family=P profiler.hbase.batch=10 profiler.hbase.flush.interval.seconds=30 +profiler.hbase.client.factory=org.apache.metron.hbase.client.HBaseTableClientFactory Review comment: The `HBaseTableClient` is an `HBaseClient` that uses HBase's `Table` abstraction in its implementation. And, for example, that is as opposed to being implemented in another way, like using HBase's `BufferedMutator` abstraction. This is how I landed on the name `HBaseTableClient`. Actually in earlier versions of this upgrade there was some legacy code that was using a `BufferedMutator`. So I had to implement an `HBaseClient` using a `BufferedMutator` to have feature parity. I called it something like `BufferedMutatorHBaseClient`. After putting in that work, I realized that the legacy code using the `BufferedMutator` was completely dead code, so I didn't need this implementation after all. If we can find a better name for this class, I'd be happy to change in a follow-on PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
