sardell opened a new pull request #1477: METRON-2199: [UI] Add ability to turn 
off query building in Alerts UI search input
URL: https://github.com/apache/metron/pull/1477
 
 
   ## Contributor Comments
   Link to ASF Jira ticket 
[here](https://issues.apache.org/jira/browse/METRON-2199).
   
   This PR gives users the option to turn off the query building feature of the 
Alerts UI search input. By clicking on the manual query button in the search 
input, they can manually input queries with Lucene syntax. If a user builds a 
query with the query builder and switch to the manual query, their currently 
built query will appear in the manual query for their use.
   
   ## Testing
   
   Open the Alerts UI. Select a time range that will return a set of alerts. If 
you click on the `Use Manual Query` button, notice that it populates the 
timestamp values in the query (from the time range selector). If you click on 
`Use Query Builder`, the input should switch back to the query builder input 
and should appear with the default `*` value.
   
   
![METRON-2199-step-1](https://user-images.githubusercontent.com/7304869/62621617-9ade6600-b91c-11e9-8080-8ab95dd0f43d.gif)
   
   With the query builder enabled, try clicking on a column value to filter 
results. Switch to the manual query input and notice that the selected value, 
as well as the timestamp, is populated in the manual query input. Try changing 
the selected value in the manual input and clicking on the search icon. You 
should see the search results refresh appropriately.
   
   
![METRON-2199-step-2](https://user-images.githubusercontent.com/7304869/62621629-9fa31a00-b91c-11e9-9158-b1761c845e0b.gif)
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? If not one needs to be 
created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   
   ### For code changes:
   - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
   - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
   - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] Have you verified the basic functionality of the build by building and 
running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - n/a ~[ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:~
   
     ```
     cd site-book
     mvn site
     ```
   
   - n/a ~[ ] Have you ensured that any documentation diagrams have been 
updated, along with their source files, using [draw.io](https://www.draw.io/)? 
See [Metron Development 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines)
 for instructions.~
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for 
your personal repository such that your branches are built there before 
submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to