sardell commented on a change in pull request #1477: METRON-2199: [UI] Add 
ability to turn off query building in Alerts UI search input
URL: https://github.com/apache/metron/pull/1477#discussion_r314338346
 
 

 ##########
 File path: 
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.spec.ts
 ##########
 @@ -104,7 +104,9 @@ describe('AlertDetailsComponent', () => {
         AuthenticationService,
         AlertsService,
         UpdateService,
-        GlobalConfigService,
+        { provide: GlobalConfigService, useValue: {
 
 Review comment:
   This line was causing an error in the console as unit tests ran because the 
service never returned an observable to subscribe to. It probably went 
unnoticed because the tests themselves wouldn't fail. Adding this stub removes 
the error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to