mmiklavc commented on a change in pull request #1453: METRON-2169: Upgrade
Kafka/Storm
URL: https://github.com/apache/metron/pull/1453#discussion_r315428399
##########
File path: metron-platform/metron-solr/metron-solr-storm/pom.xml
##########
@@ -30,30 +30,6 @@
<commons.config.version>1.10</commons.config.version>
</properties>
<dependencies>
- <dependency>
Review comment:
Can you explain the reason for the deps moving around? I'm assuming this is
to deal with some classpath issues, and it's also why this begs the question -
anything we do that changes around classpath ordering comes with it risks, and
so it should be minimized unless absolutely necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
