nickwallen commented on a change in pull request #1488: METRON-2169: Upgrade
Kafka/Storm
URL: https://github.com/apache/metron/pull/1488#discussion_r315799549
##########
File path:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/config/KafkaConfig.java
##########
@@ -111,25 +97,30 @@ public ZkUtils zkUtils() {
producerConfig.put("value.serializer",
"org.apache.kafka.common.serialization.StringSerializer");
producerConfig.put("request.required.acks", 1);
Review comment:
I think it would be a good time to replace all configuration strings with
constants. In this case we would need the producer configs.
https://kafka.apache.org/20/javadoc/?org/apache/kafka/clients/producer/ProducerConfig.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
