ruffle1986 opened a new pull request #1494: METRON-2139: Refactoring sensor-parser-config.component and wire NgRx URL: https://github.com/apache/metron/pull/1494 ## Contributor Comments Link to the original JIRA: https://issues.apache.org/jira/browse/METRON-2139 Link to Parent Feature ticket: https://issues.apache.org/jira/browse/METRON-1856 "sensor-parser-config" and "sensor-parser-config-readonly" components are responsible for displaying, creating and editing sensor data. Previously they had nothing to do with NgRx but since we're managing the state in an NgRx store, it made sense to refactor them and wire NgRx to manage the aforementioned operations. ## Related commits This PR is part of a larger sequence of PRs we are opening to make the reviewing process of the relatively large Parser Aggregation UI feature easier. To see only the changes that apply to this PR, please review the last commit in the list of commits (the commit to review contains the title of the PR) If you want to learn more about why we picked this method, please refer to the discussion thread [here](https://lists.apache.org/thread.html/5317307447c0a44491369fcf7126a3ba1d55c70a2b9d4d73f3953091@%3Cdev.metron.apache.org%3E) Please find the full list of relating PRs below. PR#1 [METRON-2114: [UI] Moving components to sensor parser module](https://github.com/apache/metron/pull/1410) PR#2 [METRON-2116: [UI] Removing redundant AppConfigService](https://github.com/apache/metron/pull/1411) PR#3 [METRON-2117: [UI] Aligning models to grouping feature](https://github.com/apache/metron/pull/1412) PR#4 [METRON-2115: [UI] Aligning UI to the parser aggregation AP](https://github.com/apache/metron/pull/1414) PR#5 [METRON-2122: [UI] Fixing early app config access issue](https://github.com/apache/metron/pull/1415) PR#6 [METRON-2124: [UI] Move status information and start/stop to the Aggregate level](https://github.com/apache/metron/pull/1418) PR#7 [METRON-2125: [UI] Making changes visible in the parser list by marking changed items](https://github.com/apache/metron/pull/1422) PR#8 [METRON-2131: Add NgRx and related dependencies](https://github.com/apache/metron/pull/1423) PR#9 [METRON-2133: Add NgRx effects to communicate with the server](https://github.com/apache/metron/pull/1424) PR#10 [METRON-2134: Add NgRx reducers to perform parser and group changes in the store](https://github.com/apache/metron/pull/1425) PR#11 [METRON-2135: Add NgRx actions to trigger state changes](https://github.com/apache/metron/pull/1426) PR#12 [METRON-2136: Add parser aggregation sidebar](https://github.com/apache/metron/pull/1427) PR#13 [METRON-2137: Implement drag and drop mechanism and wire NgRx](https://github.com/apache/metron/pull/1428) PR#14 [METRON-2138: Code clean up](https://github.com/apache/metron/pull/1429) **CURRENT PR#15 [METRON-2139: Refactoring sensor-parser-config.component and wire NgRx](https://github.com/apache/metron/pull/1430)** ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions. #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
