mmiklavc commented on a change in pull request #1493: METRON-2227 - Increase
Kafka test harness timeout
URL: https://github.com/apache/metron/pull/1493#discussion_r316694696
##########
File path:
metron-platform/metron-integration-test/src/main/java/org/apache/metron/integration/components/KafkaComponent.java
##########
@@ -65,6 +65,10 @@
public class KafkaComponent implements InMemoryComponent {
protected static final Logger LOG =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ public static final long KAFKA_PROPAGATE_TIMEOUT_MS = 10000l;
+ public static final int ZK_SESSION_TIMEOUT_MS = 30000;
+ public static final int ZK_CONNECTION_TIMEOUT_MS = 30000;
+ public static final int KAFKA_ZOOKEEPER_TIMEOUT_MS = 1000000;
Review comment:
I was on the fence about whether this should just be a string or not, but I
think having the numeric constants consistently numeric like this makes it a
bit cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
