merrimanr commented on issue #1490: METRON-2169: Upgrade to Kafka 2.0.0 and 
Storm 1.2.1
URL: https://github.com/apache/metron/pull/1490#issuecomment-524458609
 
 
   The latest commit fixes this failed test in `ProfilerIntegrationTest`:
   ```
   2019-08-23 19:02:50 ERROR executor:0 - 
   java.lang.RuntimeException: java.lang.IllegalStateException: This consumer 
has already been closed.
   ```
   My guess is that this upgrade changed the behavior of the Kafka Spout to 
close the consumer when a topology is killed.  `ProfilerIntegrationTest` is 
unique in that it starts and stops multiple topologies whereas most integration 
tests (`EnrichmentIntegrationTest`) only use one.  The fix I chose is to remove 
this step (consumer close) from the `KafkaComponent.stop` method.  The 
`KafkaComponent.shutdownConsumer` method is still available if closing the 
internal client is necessary. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to