nickwallen commented on a change in pull request #1492: METRON-2225: Upgrade to Solr 7.4.0 URL: https://github.com/apache/metron/pull/1492#discussion_r317718700
########## File path: dependencies_with_url.csv ########## @@ -434,6 +436,7 @@ org.springframework.kafka:spring-kafka:jar:1.1.1.RELEASE:compile,ASLv2,https://g org.springframework.kafka:spring-kafka:jar:2.0.4.RELEASE:compile,ASLv2,https://github.com/spring-projects/spring-kafka ch.hsr:geohash:jar:1.3.0:compile,ASLv2,https://github.com/kungfoo/geohash-java org.locationtech.spatial4j:spatial4j:jar:0.6:compile,ASLv2,https://github.com/locationtech/spatial4j +org.locationtech.spatial4j:spatial4j:jar:0.7:compile,ASLv2,https://github.com/locationtech/spatial4j Review comment: The `delete_collections.sh` script does not fully delete the collection configuration. It looks like we need to make a separate call to delete the config. This change seems to work for me. ``` diff --git a/metron-platform/metron-solr/metron-solr-common/src/main/scripts/delete_collection.sh b/metron-platform/metron-solr/metron-solr-common/src/main/scripts/delete_collection.sh index c8b45e7e..38987209 100755 --- a/metron-platform/metron-solr/metron-solr-common/src/main/scripts/delete_collection.sh +++ b/metron-platform/metron-solr/metron-solr-common/src/main/scripts/delete_collection.sh @@ -31,3 +31,6 @@ SOLR_NODE=`$ZOOKEEPER_HOME/bin/zkCli.sh -server $ZOOKEEPER ls /live_nodes | tail # Delete the collection curl -X GET $NEGOTIATE "http://$SOLR_NODE/solr/admin/collections?action=DELETE&name=$1"; + +# Delete the config set +curl -X GET $NEGOTIATE "http://$SOLR_NODE/solr/admin/configs?action=DELETE&name=$1"; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
