[ 
https://issues.apache.org/jira/browse/METRON-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922347#comment-16922347
 ] 

Dale Richardson commented on METRON-2237:
-----------------------------------------

The new docker rpm infrastructure means that the npm state can no longer 
persist between builds.  Moving npm installs outside of rpm construction may 
still make sense though.

> Metron RPM Build - Move npm installs outside of RPM construction
> ----------------------------------------------------------------
>
>                 Key: METRON-2237
>                 URL: https://issues.apache.org/jira/browse/METRON-2237
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Dale Richardson
>            Priority: Minor
>
> An extract from: 
> metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec
> {code:java}
> allows node dependencies to be packaged in the RPMs
>  {{ npm install --prefix="%{buildroot}%{metron_home}/web/expressjs" 
> --only=production}}{code}
> It probably makes sense to keep this sort of packaging detail external to the 
> RPM build and as a responsibility of the respective Maven modules.
> In certain circumstances the npm repos get left lying around as persistent 
> state in the build tree.  This cannot be tidied up be a mvn clean and causes 
> subsequent build failures.  (c.f. METRON-2234) 
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to