ottobackwards opened a new pull request #36: METRON-2069 Add btests for bro plugin topic_name selection URL: https://github.com/apache/metron-bro-plugin-kafka/pull/36 - add btests for different configuration options - add docker run_end_to_end option to surpess pcaps so you can just build the plugin and run btests as part of bro-pkg - add new plugin configuration for `mock`. When this is set to `T`, the plugin will not create or call anything todo with Kafka, this is so you can test without kafka running ## Testing ```bash >run_end_to_end.sh --no-pcap and observer tests pass ``` ``` bash >run_end_to_end.sh ``` In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed via: ``` bro-pkg test $GITHUB_USERNAME/metron-bro-plugin-kafka --version $BRANCH ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] run in docker with run_end_to_end.sh
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
