mmiklavc commented on a change in pull request #1515: METRON-2261 Isolate
Curator Dependencies
URL: https://github.com/apache/metron/pull/1515#discussion_r326308716
##########
File path: metron-analytics/metron-maas-service/pom.xml
##########
@@ -59,6 +59,23 @@
<artifactId>hadoop-yarn-server-common</artifactId>
<version>${hadoop.version}</version>
<scope>provided</scope>
+ <exclusions>
Review comment:
One thing we might consider with these bigger dep exclusions (and this is
just an idea, entirely up to you) is using wildcards.
```
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>2.7.1</version>
<exclusions>
<exclusion>
<groupId>org.apache.curator</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
```
I found this results in all curator deps from hadoop-common being excluded
whereas previously I had the following:
```
grep curator /tmp/deptree.txt
[INFO] | \- org.apache.curator:curator-framework:jar:2.7.1:compile
[INFO] +- org.apache.curator:curator-client:jar:2.7.1:compile
[INFO] +- org.apache.curator:curator-recipes:jar:2.7.1:compile
```
I'm not sure if this is too big a net to cast or not. The dependency plugin
doesn't appear to do globs, only full wildcard matching at the artifactId or
groupId level. e.g. "curator*" will not work in the artifactId, unfortunately.
Just an idea.
This is the Maven feature - https://issues.apache.org/jira/browse/MNG-2315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
