tigerquoll opened a new pull request #1517: METRON-2256 NodeJS Module puppeteer moved to be a dev dependency. URL: https://github.com/apache/metron/pull/1517 The puppeteer module is used for GUI testing, and allows Chrome to be driven headless for GUI testing purposes. Every time that puppeteer is installed, (which is every build), it downloads Chrome (80-120 MB download, 250+ MB on disk). Puppeteer cannot be configured to cache the download for future use. Angular/NodeJS has a concept a dev dependency, which is only installed for testing. Dev-dependencies are not installed during a full dev build/deployment. Moving puppeteer to be a dev-dependency means that Chrome is only downloaded when automated testing is about to happen. This patch works against Master before Metron-2243 was merged on 3rd September. Past that date, an issue that prevents automated GUI tests from completely correctly was inadvertently introduced, and thus automated GUI testing cannot confirm correct operation. Once this issue has been identified this PR will be updated to Merge with the current Master branch. Manual testing. run. mvn clean install -pl :metron-alerts -DskipTests Verify the following lines are not present > puppeteer@1.19.0 install /Users/dale/work/metron-testing/metron-interface/metron-alerts/node_modules/puppeteer > node install.js [ERROR] Chromium downloaded to /Users/dale/work/metron-testing/metron-interface/metron-alerts/node_modules/puppeteer/.local-chromium/mac-674921 Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - n/a Have you written or updated unit tests and or integration tests to verify your changes? - n/a If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - n/a Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` - n/a Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions. #### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
