justinleet commented on issue #36: METRON-2069 Add btests for bro plugin 
topic_name selection
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/36#issuecomment-533641585
 
 
   wget isn't installed by default on Mac, iirc. We should either be using 
curl, or documenting the requirement. I believe this is preexisting and 
therefore outside the scope of this ticket though.
   
   In a similar vein, I tried running this up, but turns out it breaks before I 
even get to that point because we require bash >= 4.0. Which is also not 
installed on Mac by default. It's not related to this ticket, but that should 
be documented in the READMEs, assuming we can't actually make it work in 3.2 
(Looks like it's using associative arrays, which we probably could refactor out 
if we really cared to). It's personally annoying that I have to update the 
shell on my system to use this.
   
   Do we need a Jira to either a) document the dependencies users need to have 
for this or b) refactor to avoid requiring these dependencies?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to