tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327021709
##########
File path: metron-interface/metron-alerts/src/app/utils/httpUtil.ts
##########
@@ -33,9 +33,12 @@ export class HttpUtil {
return body || {};
}
+ /**
+ * @depricated Turning all errors to 404 and hiding actual errors from the
consumers
+ * could limit how we can recover or react to errors.
+ * Use sessionExpiration instead and/or introduce new composable
error handlers.
+ */
public static handleError(res: HttpErrorResponse): Observable<RestError> {
- // In a real world app, we might use a remote logging infrastructure
- // We'd also dig deeper into the error to get a better message
Review comment:
If we once accepted to have comments like this in the code using // FIXME is
also acceptable I think. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
