ottobackwards commented on a change in pull request #36: METRON-2069 Add btests 
for bro plugin topic_name selection
URL: 
https://github.com/apache/metron-bro-plugin-kafka/pull/36#discussion_r327830972
 
 

 ##########
 File path: .gitignore
 ##########
 @@ -39,5 +39,5 @@ build
 # Log files
 *.log
 # pcap files
-*.pcap
-*.pcapng
 
 Review comment:
   @nickwallen we are testing that the topic resolved is getting called.  
Commenting out that code won't effect that.  Or am I missing something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to