mmiklavc commented on a change in pull request #1521: METRON-2267: Audit
Zookeeper config changes in REST
URL: https://github.com/apache/metron/pull/1521#discussion_r329680021
##########
File path:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/SensorEnrichmentConfigController.java
##########
@@ -50,6 +56,7 @@
@RequestMapping(value = "/{name}", method = RequestMethod.POST)
ResponseEntity<SensorEnrichmentConfig> save(@ApiParam(name="name",
value="SensorEnrichmentConfig name", required=true)@PathVariable String name,
@ApiParam(name="sensorEnrichmentConfig", value="SensorEnrichmentConfig",
required=true)@RequestBody SensorEnrichmentConfig sensorEnrichmentConfig)
throws RestException {
+ LOG.info(String.format("User '%s' changed the '%s' enrichment config to
%s", SecurityUtils.getCurrentUser(), name, sensorEnrichmentConfig.toString()));
Review comment:
We should be using slf4j tokenization instead of String.format()
```
LOG.info("User '{}' changed the '{}' enrichment config to {}",
SecurityUtils.getCurrentUser(), name, sensorEnrichmentConfig.toString());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
