sardell commented on a change in pull request #1507: METRON-2251: Update with
the latest master branch
URL: https://github.com/apache/metron/pull/1507#discussion_r332213353
##########
File path:
metron-interface/metron-config/src/app/sensors/effects/sensors.effects.spec.ts
##########
@@ -129,16 +129,18 @@ describe('sensor.effects.ts', () => {
store.dispatch(new fromActions.ApplyChanges());
});
- it('Should show notification when operation SUCCESSFULL', () => {
- store.dispatch(new fromActions.ApplyChanges());
- expect(userNotificationSvc.showSuccessMessage).toHaveBeenCalled();
- });
+ // Removing these tests until we rewrite this test suite to use a mock store
and mock actions
Review comment:
It does now: https://issues.apache.org/jira/browse/METRON-2277
Thanks for pointing this out, @mmiklavc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
