mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549877351 @ottobackwards Any thoughts on this comment also? https://github.com/apache/metron/pull/1546#issuecomment-548510246 WRT shellcheck, I fixed a couple issues, as indicated in my earlier comments. Here's the current output - https://gist.github.com/mmiklavc/bb9cd52994a0ca6c598a960787871d66. This script currently matches our style and patterns on escaping/variable expansion in all our other shell scripts. Anything I'm missing you're specifically requesting? I don't think I agree with the checker that we should go quoting every variable in this case, but maybe there's a good reason for it. Minimally, if we think it's worthwhile to use shellcheck as a passing standard, I think that's worth a discuss thread about the tool, how it compares to others, what we do/don't expect of it, etc.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
