ottobackwards commented on issue #1546: METRON-2239 Metron Automated backup and restore URL: https://github.com/apache/metron/pull/1546#issuecomment-549912826 @JonZeolla and I have been using shellcheck for all of our bro testing scripts, and I used it for the RC scripts and the common script as well. I don't think I would call the existing bash scripts style and practice. I think it is a good practice, and makes it really clear for everyone contributing to script code what is required. That being said, it is _not_ the project standard, so I can't make you do it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
