mmiklavc commented on issue #1563: METRON-2318: Merge master into feature branch URL: https://github.com/apache/metron/pull/1563#issuecomment-555142581 @sardell - I think I see what's going on here. I don't think I realized the previous merge was squashed. That's more an issue of community documentation than anything else - I don't think we have a page with our past learnings put together yet. In other FB's, I don't think we squashed the merge commit. It makes the git history more jagged, but also preserves history so we don't have to deal with gnarly redundant merges (like we see in the history for this PR). When we're confident in this merge, I think we should commit it to the FB as a normal merge commit, not squashed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
