nickwallen commented on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-555510328 It is failing when building the RPMs. It is really difficult to discern error messages via the Ansible output, so what I usually do is figure out where it is failing in the build process, then just run that command myself on the command line. When building the RPMS, we get this error output. ``` $ cd metron-deployment/ $ mvn clean package -Pbuild-rpms ... RPM build errors: error: Installed (but unpackaged) file(s) found: /usr/metron/0.7.2/web/expressjs/package-lock.json Macro %_prerelease has empty body Macro %_prerelease has empty body Installed (but unpackaged) file(s) found: /usr/metron/0.7.2/web/expressjs/package-lock.json RPM build errors encountered ``` I see there is a `package-lock.json` that is present in the location where the RPMs are being packaged. ``` $ find ./ -name package-lock.json .//packaging/docker/rpm-docker/BUILDROOT/metron-0.7.2-root/usr/metron/0.7.2/web/expressjs/package-lock.json ``` But I do not see a `package-lock.json` defined in the `metron.spec` file. Am I correct in assuming that we should NOT be including this file in the RPMs?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
