justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348642487
##########
File path:
metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/integration/PcapTopologyIntegrationTest.java
##########
@@ -220,13 +208,13 @@ public static void setupTopology(Function<Properties,
Void> updatePropertiesCall
clearOutDirs(inputDir, interimResultDir, outputDir);
File baseDir = new File(new File(targetDir), BASE_DIR);
- //Assert.assertEquals(0, numFiles(outDir));
- Assert.assertNotNull(topologiesDir);
- Assert.assertNotNull(targetDir);
+ //assertEquals(0, numFiles(outDir));
Review comment:
Honestly, I have no idea without digging what the test actually does and if
that assertion would be meaningful or not. I can look into it more if you want.
Unrelated, this file is absolutely lousy with `System.out`. We really should
get our test output cleaned up and use the utilities we have for managing
logging more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
