justinleet edited a comment on issue #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#issuecomment-556131586 @mmiklavc This is pretty important, so I'm flagging you directly on the comment. I'm looking into some weirdness with our `verify_licenses.sh`. It produces different results for me on Travis than locally and implies I need to readd the deps (because seems right: e.g. JUnit is a correct dependency of our compiled source: specifically `metron-integration-test`). The difference between local and Travis seems to be that our shell scripts are faulty. They try to `exit` if an error occurs, but `exit` during a pipe chain doesn't stop the chain, so it ends up passing along to builtins that exit with 0 (because for `grep`, `sort`, etc, nothing went wrong). Note that `mvn dependency:list` should pretty much always fail midway because we don't have the Metron artifacts built, so we can't run a build all the way through (because it can't find intermodule deps). To see this sort of thing in action: ``` { echo "test" && exit 1 } | grep t echo $? ``` This will still run the grep on test, and because the grep succeeds, the return code is 0. I've changed this branch to reflect, and ~~will open a PR~~ PR is #1568.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
