nickwallen opened a new pull request #1573: METRON-885 Build RPMs in Travis URL: https://github.com/apache/metron/pull/1573 We should focus on improving our CI builds to catch as many problems as possible and rely less on manual testing and due diligence. One gap we have now is that if a change is submitted that breaks the RPMs, the CI build will not detect the problem. This kind of problem can only be detected by relying on our contributors and committers to dutifully run-up the development environment. This change allows for the RPMs to be built as part of the Travis CI build. If the RPMs fail to build, the Travis CI build should fail. #### Point to Consider for Reviewers Building the RPMs requires a complete build of Metron. This will likely push our backs up against the 50 minute time window allowed by Travis. If this change risks causing numerous intermittent test failures due to the time window, I do not want to introduce this change until we can address that problem. #1522 gave us some breathing room, but did not solve the problem. I will confirm that this is indeed the case and comment on this PR. ## Changes This adds an additional step "Build RPMs" that builds the Metron RPMs in parallel with the other build and validation steps. ## Testing 1. Break the RPM build by modifying the metron.spec. 1. Ensure the Travis CI build fail. 1. Fix the `metron.spec`. 1. Ensure the Travis CI build runs succecssfully. ## Pull Request Checklist - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
