nickwallen commented on issue #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures URL: https://github.com/apache/metron/pull/1568#issuecomment-562699207 All the changes are looking good. I am just seeing one issue with the validation. I took this branch and removed the `junit` addition to `dependencies_with_url.csv`. I would expect validation to fail in this case. Unfortunately, when running in Travis CI the job does not fail. * See https://travis-ci.org/nickwallen/metron/builds/621740129. When running locally everything builds correctly and I see an error message, but the return code is still 0, when it should probably be non-zero. ``` $ time ./dev-utilities/build-utils/verify_licenses.sh ... Determining dependencies Traceback (most recent call last): File "dev-utilities/build-utils/verify_license.py", line 44, in <module> raise ValueError("Unable to find these components: \n " + "\n ".join(components_not_found) + "\nin the acceptable list of components: " + sys.argv[1]) ValueError: Unable to find these components: junit:junit:jar:4.12:compile in the acceptable list of components: ./dependencies_with_url.csv Finished validating dependencies. real 2m29.260s user 9m8.852s sys 0m32.922s $ echo $? 0 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
