sardell commented on issue #1575: METRON-2335: [UI] Implement synchronization between browser user state and Hbase user state URL: https://github.com/apache/metron/pull/1575#issuecomment-565442931 @ruffle1986 Thanks for the thorough explanation. > So basically it's an issue on the level of the implementation of these features (like auto polling, show/hide, etc.) and not on the new service's level. > So in my opinion, if it's suboptimal now, it was suboptimal before as well and I didn't want to optimise the features because it's already a big PR with lots of changes and I didn't want to increase the difficulty for the reviewer because, in my opinion, it's out of the scope of this issue. I completely agree with you, and I appreciate your consideration for the reviewer(s) of this PR. We can make changes to the actual component implementations in another PR to keep this scope of work focused on the task you set out to accomplish. I'm a +1 on this, but I'm going to let it sit for another day to make sure others have a chance to weigh in if they want. Thanks for the contribution, @ruffle1986!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
