[ 
https://issues.apache.org/jira/browse/METRON-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507629#comment-15507629
 ] 

ASF GitHub Bot commented on METRON-426:
---------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/257#discussion_r79698302
  
    --- Diff: 
metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java
 ---
    @@ -173,6 +173,22 @@ public void testMapConstant() {
       }
     
       @Test
    +  public void testArithmetic() {
    +    {
    +      String query = "1 + 2";
    +      Assert.assertEquals(3, ((Number)run(query, ImmutableMap.of("casey", 
"casey"))).doubleValue(), 1e-3);
    +    }
    +    {
    +      String query = "1.2 + 2";
    +      Assert.assertEquals(3.2, ((Number)run(query, 
ImmutableMap.of("casey", "casey"))).doubleValue(), 1e-3);
    +    }
    +    {
    +      String query = "1.2e-3 + 2";
    +      Assert.assertEquals(1.2e-3 + 2, ((Number)run(query, 
ImmutableMap.of("casey", "casey"))).doubleValue(), 1e-3);
    +    }
    --- End diff --
    
    The `ImmutableMap.of("casey","casey")`(besides promoting your global brand 
;) ) do nothing for these tests, right?  It'd be more clear, if we removed 
those.  Everything else looks good.  I'm a +1 if we can take care of this small 
issue.


> Stellar does not support scientific notation as a literal
> ---------------------------------------------------------
>
>                 Key: METRON-426
>                 URL: https://issues.apache.org/jira/browse/METRON-426
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Casey Stella
>            Assignee: Casey Stella
>             Fix For: 0.2.1BETA
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Stellar does not support scientific notation for expressing literal doubles.  
> It should.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to