[
https://issues.apache.org/jira/browse/METRON-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510300#comment-15510300
]
ASF GitHub Bot commented on METRON-438:
---------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/265#discussion_r79862290
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/shell/StellarShell.java
---
@@ -244,6 +304,55 @@ private void write(String out) {
}
private void writeLine(String out) {
- System.out.println(out);
+ console.getShell().out().println(out);
+ }
+
+ @Override
+ public int execute(ConsoleOperation output) throws InterruptedException {
+ String expression = output.getBuffer().trim();
+ if(StringUtils.isNotBlank(expression)) {
+ if(isMagic(expression)) {
+ handleMagic( expression);
+
+ } else if(isDoc(expression)) {
+ handleDoc(expression);
+
+ } else if (expression.equals("quit")) {
+ try {
--- End diff --
Does this prevent the user from referring to a variable called `quit`? If
so, maybe `%quit`?
> Back the Stellar REPL with a readline implementation
> ----------------------------------------------------
>
> Key: METRON-438
> URL: https://issues.apache.org/jira/browse/METRON-438
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Assignee: Casey Stella
> Original Estimate: 2.5h
> Remaining Estimate: 2.5h
>
> The REPL as it currently stands is great, but it could be closer in-line with
> the more popular REPL's by being backed by a readline implementation.
> Specifically, we should:
> * add variable assignment
> * add the ability to do reverse searches in the history
> * add the ability to use the arrow keys to recover previous inputs
> * add the ability to adjust input via ~/.inputrc
> * add autocomplete for function names and variable names
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
