[ 
https://issues.apache.org/jira/browse/METRON-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568930#comment-15568930
 ] 

ASF GitHub Bot commented on METRON-424:
---------------------------------------

GitHub user ottobackwards reopened a pull request:

    https://github.com/apache/incubator-metron/pull/303

    METRON-424 ability to validate ip addresses against both IPV4 and IPV6

    Allow the specification of multiple validation types for IP
    ` 
       {
         "fieldValidations" : [
         {
           "input" : [ "field1", "field2" ]
           ,"validation" : "IP"
           ,"config" : {
           "type" : ["IPV4","IPV6"]
         }
       }
       ]
       }`
    
    The question with this PR is if this is the correct approach.  Is this the 
most consistent approach?  Is it the least surprising?  Would it be better to 
add a ALL keyword such that instead of specifying both types you can just do
    
    "type": "ALL"?
    
    I did it this way to start, but I'm open to change it based on review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/incubator-metron METRON-424

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #303
    
----
commit 9064ec0cdc38c54bf3a5309bad200f1f27d3c00a
Author: Otto Fowler <ofow...@industrialdefender.com>
Date:   2016-10-11T14:57:02Z

    METRON-424 ability to validate ip addresses against both IPV4 and IPV6

----


> Stellar fieldValidation "IP" does not support list values
> ---------------------------------------------------------
>
>                 Key: METRON-424
>                 URL: https://issues.apache.org/jira/browse/METRON-424
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Neha Sinha
>
> Currently, stellar fieldValidation *IP* accepts only single string 
> value.However we need the ability to specify a list of values,say, we want to 
> validate ip_dst_addr to be of either IPV4 or IPV6 type. This feature needs to 
> be incorporated.
> Desired Behaviour :- User should be able to configure ip validation as below 
> :-
> GLOBAL Config: global
> {
>   "es.clustername": "metron",
>   "es.ip": "metron-test1-10.openstacklocal",
>   "es.port": "9300",
>   "es.date.format": "yyyy.MM.dd.HH",
>   "fieldValidations" : [
>               {
>                 "input" : [ "ip_dst_addr" ],
>                 "validation" : "IP",
>                 "config" : {
>                     "type" : ["IPV6","IPV4"]
>                            }
>               }
>                        ]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to