ASF GitHub Bot commented on METRON-502:

Github user cestella commented on the issue:

    @ottobackwards I was suggesting that `printBadResults` take a StringBuffer 
where what would be printed is accumulated and then passed back.  Then in the 
individual tests, you could decide what to do with the StringBuffer.  I'd 
suggest passing it to `Assertion.fail` so it bubbles to the top of the test.
    If you do change `printBadResults` to do that, you might consider changing 
it to `getBadResults` or something that doesn't imply printing.

> Make the ParserIntegrationTest more clear on errors
> ---------------------------------------------------
>                 Key: METRON-502
>                 URL: https://issues.apache.org/jira/browse/METRON-502
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.2.1BETA
>            Reporter: Casey Stella
> Right now the ParserIntegrationTest fails if it does not receive the expected 
> number of messages after a given amount of time.  In situations where 
> messages get redirected to the error or invalid queues, this results in the 
> test waiting and failing at the end of a timeout.  The developer cannot 
> determine if the cause is a timeout or actual errors.
> We should, instead, dump out the error and invalid queue as soon as it 
> becomes populated and fail the test with more specific reason.

This message was sent by Atlassian JIRA

Reply via email to