[
https://issues.apache.org/jira/browse/METRON-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626730#comment-15626730
]
ASF GitHub Bot commented on METRON-529:
---------------------------------------
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/334#discussion_r86029202
--- Diff:
metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java
---
@@ -91,12 +91,12 @@
/**
* A global property that defines the name of the column family used to
store profile data.
*/
- public static final String PROFILER_COLUMN_FAMILY =
"profiler.client.column.family";
+ public static final String PROFILER_COLUMN_FAMILY =
"profiler.client.hbase.column.family";
/**
* A global property that defines the name of the HBaseTableProvider
implementation class.
*/
- public static final String PROFILER_HBASE_TABLE_PROVIDER =
"profiler.client.hbase.table.provider";
+ public static final String PROFILER_HBASE_TABLE_PROVIDER =
"hbase.provider.impl";
--- End diff --
This isn't an objection, just a question: I'm not yet real familiar with
the structure of the configuration tree in ZK. Is this "hbase.provider.impl"
parameter stored in a part of the tree where it clearly ONLY applies to
profiler? Otherwise I would prefer to leave it with a "profiler." prefix.
> Allow Configurable Periods for Profiler Client
> ----------------------------------------------
>
> Key: METRON-529
> URL: https://issues.apache.org/jira/browse/METRON-529
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
>
> By default, the Profiler creates Profiles with a period duration of 15
> minutes. This means that data is accumulated, summarized and flushed every 15
> minutes. The Client API must also have knowledge of this duration to
> correctly retrieve the profile data. If the client API is expecting 15 minute
> periods, it will not be able to read data generated by a Profiler that has
> been configured with a 1 hour period.
> The period duration can be configured in the Profiler by altering the
> Profiler topology's static properties file. The Stellar Client API currently
> provides no means to configure the period duration and defaults also to 15
> minutes. This means that the Stellar Client API can only read profiles with a
> period duration of 15 minutes. This is a known limitation that has not yet
> been addressed.
> https://github.com/apache/incubator-metron/blob/e31705029fd7518bd03c22eece0c2a8eb1187abf/metron-analytics/metron-profiler-client/README.md#period-duration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
