[
https://issues.apache.org/jira/browse/METRON-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648662#comment-15648662
]
ASF GitHub Bot commented on METRON-556:
---------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/incubator-metron/pull/348
METRON-556: Profiler - Refactor 'Group By' Calculation
### [METRON-556](https://issues.apache.org/jira/browse/METRON-556)
Refactored how the 'group by' expressions are evaluated. This lays some
groundwork for future changes on the Profiler. See the JIRA for additional
description of the change
Tested in "Quick Dev" environment by repeating the [demo that is described
here](https://youtu.be/vOMZcudmlYg).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/incubator-metron METRON-556
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #348
----
commit 40d1856ad9597915d576ad5ba8f60c624ac8ec55
Author: Nick Allen <[email protected]>
Date: 2016-11-08T18:22:33Z
METRON-556 Profiler - Refactor 'Group By' Calculation
commit de3f2636ade15a497ed18aacc0d5c4a1ba7caace
Author: Nick Allen <[email protected]>
Date: 2016-11-08T20:04:33Z
Merge remote-tracking branch 'upstream/master' into METRON-556
----
> Profiler - Refactor 'Group By' Calculation
> ------------------------------------------
>
> Key: METRON-556
> URL: https://issues.apache.org/jira/browse/METRON-556
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
>
> Currently a Profile's 'group by' expression is calculated in the context of
> the HBaseBolt. Specifically it is calculated in the ProfileHBaseMapper.
> This mapper is run by the HBaseBolt to define how the Profile values stored
> in a tuple get written to HBase. This can be refactored so that the 'group
> by' expression is calculated at the same time as the 'result' expression in
> the context of the ProfileBuilderBolt.
> This has a few advantages. It allows any errors encountered in executing the
> 'group by' expression to be contained within the ProfileBuilderBolt instance
> responsible for the profile/entity pair alone. Any exceptions cannot impact
> the functioning of the rest of the Profiler. This is also more consistent
> and simple as the HBaseBolt will receive everything that it needs,
> pre-calculated, in the form of a ProfileMeasurement object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
