[ 
https://issues.apache.org/jira/browse/METRON-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654512#comment-15654512
 ] 

ASF GitHub Bot commented on METRON-538:
---------------------------------------

Github user ottobackwards commented on the issue:

    https://github.com/apache/incubator-metron/pull/344
  
    Ok, looking at the log - my change did not resolve that issue.  I’ll keep
    looking.
    
    
    
    On November 10, 2016 at 11:43:08, Otto Fowler ([email protected])
    wrote:
    
    I took a stab at that in my last commit, but have not checked the travis
    log this morning, sorry.
    Here is what I think is happening.
    
    The parser tests do ( or did ) not create the ENRICHMENT topic when setting
    up KafkaWithZK.  So, with auto create it will get created and work
    eventually - but there is a chance that you will see errors for the
    attempts to ‘trigger’ the auto creation.
    
    I did not see those errors locally - only in travis.   When checking last
    night against the travis log - i noticed them and tried creating the topic
    to address.
    
    I did not check the travis log this morning for it though, sorry.
    
    
    
    
    On November 10, 2016 at 11:07:09, David Lyle ([email protected])
    wrote:
    
    Hi @ottobackwards <https://github.com/ottobackwards> - thanks for taking
    this on, looking over the log, it looks like a huge improvement.
    
    I am seeing a bunch of these:
    
    2016-11-10 05:08:02 ERROR KafkaApis:103 - [KafkaApi-0] Error when handling
    request {topics=[enrichments]}
    
    type errors in the log happening during various parser tests. What's your
    sense of these? Are these happening due to out of order set up and the
    tests are passing?
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub
    
<https://github.com/apache/incubator-metron/pull/344#issuecomment-259730544>,
    or mute the thread
    
<https://github.com/notifications/unsubscribe-auth/ABD1__UNuguvEPQUJNNvjqZLkoSVbAeeks5q80EqgaJpZM4Ko3rd>
    .



> Ensure proper shutdown, exceptions of integration test components
> -----------------------------------------------------------------
>
>                 Key: METRON-538
>                 URL: https://issues.apache.org/jira/browse/METRON-538
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.2.2BETA
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Critical
>
> The integration test components use to test with kafka, in mem cluster and 
> zookeeper can be left in a failed state, where they are not shut down and 
> their resources released.  This can lead to cascading failures in the testing 
> environment and log pollution.
> The components and their use should be refactored such that they are always 
> shut down properly, and log appropriately.
> Some examples will be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to